Minor test tweaks - #12229
Merged
openshift-merge-robot merged 1 commit intoNov 8, 2021
Merged
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Contributor
|
LGTM |
Luap99
reviewed
Nov 8, 2021
Member
There was a problem hiding this comment.
This also needs podman unshare --rootless-cni cat /etc/resolv.conf (make sure to only run this as rootless user)
and the output of ps uxww
- remove 'NO TESTS NEEDED' as a valid bypass string. Henceforth only 'NO NEW TESTS NEEDED' will work. - add a debugging aid for podman-container-tools#11871, in which bodhi tests time out in nslookup. Signed-off-by: Ed Santiago <santiago@redhat.com>
edsantiago
force-pushed
the
minor_test_tweaks
branch
from
November 8, 2021 21:24
eb1c0cd to
2ed31f9
Compare
Contributor
|
/lgtm |
openshift-ci
Bot
added
the
do-not-merge/hold
Contributor
Author
|
/hold cancel thanks |
openshift-ci
Bot
removed
the
do-not-merge/hold
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Nov 15, 2021
Followup to podman-container-tools#12229, in which I added a podman unshare for flake debugging. Turns out that doesn't work in podman-remote. It was not caught because CI doesn't run podman-remote rootless. Signed-off-by: Ed Santiago <santiago@redhat.com>
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Nov 22, 2021
[Backport of podman-container-tools#12297 into v3.4, to fix gating-test failures] Followup to podman-container-tools#12229, in which I added a podman unshare for flake debugging. Turns out that doesn't work in podman-remote. It was not caught because CI doesn't run podman-remote rootless. Signed-off-by: Ed Santiago <santiago@redhat.com>
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Nov 23, 2021
Followup to podman-container-tools#12229, in which I added a podman unshare for flake debugging. Turns out that doesn't work in podman-remote. It was not caught because CI doesn't run podman-remote rootless. Signed-off-by: Ed Santiago <santiago@redhat.com>
github-actions
Bot
added
the
locked - please file new issue/PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove 'NO TESTS NEEDED' as a valid bypass string. Henceforth
only 'NO NEW TESTS NEEDED' will work.
add a debugging aid for Network create test: nslookup: timed out, no servers could be reached #11871, in which bodhi tests time out
in nslookup.
Signed-off-by: Ed Santiago santiago@redhat.com